fix(browsertracing/inp): Ensure interactionIdToRouteNameMapping[id] is defined before destructuring #11157
Closed
fix(browsertracing/inp): Ensure interactionIdToRouteNameMapping[id] is defined before destructuring #11157
interactionIdToRouteNameMapping[id] is defined before destructuring #11157Conversation
… is defined before destructuring
3 tasks
Contributor
size-limit report 📦
|
edwardgou-sentry
previously approved these changes
Mar 18, 2024
Contributor
edwardgou-sentry
left a comment
edwardgou-sentry
left a comment
There was a problem hiding this comment.
Thanks @Lms24 ! lgtm, I'll take a look to see why its undefined in the first place
Contributor
|
Hey @Lms24 , I thought about this a little bit and I think I know why the mapping is returning undefined. I'll put up a pr that will handle this scenario better, sorry for the inconvenience! Feel free to close this pr! |
Member
Author
|
Thanks @edwardgou-sentry no worries, as I said, I'm happy to close this in favor of a better fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix for #11156 but I'm not sure how we run into the error in the first place. @edwardgou-sentry would you mind taking a look? Happy to close my PR for a better fix :)
ref #11156